Search found 1 match

by dcb314
29 Oct 2013, 15:45
Forum: Partition Recovery
Topic: testdisk-6.14: 3 * possible bad if tests ?
Replies: 0
Views: 1180

testdisk-6.14: 3 * possible bad if tests ?

Hello there,

I just compiled testdisk-6.14 with extra Linux gcc flag -Wlogical-op

It said

1.

file_dbf.c:56:3: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

if(buffer[0]==0x3 && (buffer[1]>80 || buffer[1]<120) &&

Suggest swap || for &&

2 ...