Copying - feature requests

Using PhotoRec to recover lost data
Post Reply
Message
Author
GCRaistlin
Posts: 9
Joined: 09 Feb 2013, 21:35

Copying - feature requests

#1 Post by GCRaistlin » 14 Mar 2013, 21:28

  1. Copying files using TestDisk could be a long process. Currently, an user gets almost no info about the process. Name of the file being copied, done percent, estimated time are worth to be displayed.
  2. Destination folder is being selected once per session. But an user may expect that TestDisk will ask him for destination folder again before next copy. It may be dangerous. It is better to display destination directory name on screen when it is selected.

Sponsored links

User avatar
cgrenier
Site Admin
Posts: 3613
Joined: 18 Feb 2012, 15:08
Location: Le Perreux Sur Marne, France
Contact:

Re: Copying - feature requests

#2 Post by cgrenier » 25 Mar 2013, 21:45

I have uploaded a new 6.14-WIP version. Can you test it ?
You will be asked for a new destination if you change of source directory.

GCRaistlin
Posts: 9
Joined: 09 Feb 2013, 21:35

Re: Copying - feature requests

#3 Post by GCRaistlin » 03 Apr 2013, 17:54

  1. It asks for a new destination only if source dir was changed after last copying - i.e., another file from the same dir will be copied to the same destination dir. I don't want to say that this behaviour is wrong - but I expected that it will ask for destination dir for every copy operation.
  2. Existing files are being overwritten without any prompt!
  3. Still no progress bar, even no "Copying in progress" message? In case of broken HDD led an user can't even tell if copying is in progress or TestDisk just hangs.
    UPD: I got it: "Copying, please wait..." was overwritten by too long source file name.
  4. If name of the file that will be copied too long we miss important info on the screen - what should I press to start copying?

    Code: Select all

    TestDisk 6.14-WIP, Data Recovery Utility, March 2013
    
    Please select a destination where /Video/Идиот _ Hakuchi _ Idiot
    (Акира Куросава _ Akira Kurosawa) [1951, Япония, Драма,
    DVD9 (custom)] DVO + VO + Orig + 2 x Sub Rus + Sub En and any files below will
    be copied.en the destination is correct
          Q to quit
    
    >d--------- 4294967295 4294967295         0  3-Apr-2013 20:00 c
     drwxr-xr-x   400   401         0 27-Apr-2012 11:30 d
     drwxrwx--- 4294967295 4294967295         0  3-Apr-2013 02:57 j
     drwxrwx--- 4294967295 4294967295         0 24-Jul-2012 03:05 k
     drwxr-xr-x   400   401         0  1-Jan-1980 00:00 l
     drwx------ 4294967295 4294967295         0  5-Dec-2012 04:28 o
     drwx------ 4294967295 4294967295         0 15-Aug-2012 14:11 p
     drwx------ 4294967295 4294967295         0  2-Apr-2013 13:35 q
     drwx------ 4294967295 4294967295         0  3-Apr-2013 15:04 r
    
  5. Files and folders are being listed unsorted. If possible classic sorting will be comfortable: by name, folders first.
  6. Is there a way to hide "phantom" files?

    Code: Select all

    TestDisk 6.14-WIP, Data Recovery Utility, March 2013
    Christophe GRENIER <grenier@cgsecurity.org>
    http://www.cgsecurity.org
     1 P HPFS - NTFS              0  65  2 243201  78 13 3907024896 [RYA-10]
    Directory /Video/Любит... не любит _ A la folie... pas du tout _ He Loves Me... He Loves Me Not (Л
    етиция Коломбани _ Laetitia Colombani) [2002 г., Др
    >dr-xr-xr-x     0     0         0 28-Oct-2010 01:57 .
     dr-xr-xr-x     0     0         0  3-Apr-2013 15:00 ..
     -r--r--r--     0     0 1570594816 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0         0 28-Oct-2010 01:54 Lubit_ne_lubit.DVDRip_(torrents.ru).avi
     -r--r--r--     0     0        50 28-Oct-2010 01:57 URL.txt
    
    And you may notice that current dir name is being displayed cut (it doesn't actually end with "2002 г., Др").

User avatar
cgrenier
Site Admin
Posts: 3613
Joined: 18 Feb 2012, 15:08
Location: Le Perreux Sur Marne, France
Contact:

Re: Copying - feature requests

#4 Post by cgrenier » 21 Apr 2013, 08:46

I have uploaded a new 6.14-WIP. It should with the missing information problem you listed in 4. Can you try it ?

GCRaistlin
Posts: 9
Joined: 09 Feb 2013, 21:35

Re: Copying - feature requests

#5 Post by GCRaistlin » 22 Apr 2013, 00:38

  1. New version displays (before file to copy is being selected):

    Code: Select all

    TestDisk 6.14-WIP, Data Recovery Utility, April 2013
    Christophe GRENIER <grenier@cgsecurity.org>
    http://www.cgsecurity.org
     1 P HPFS - NTFS              0  32 33 243201  45 44 3907024896 [RYA-3]
    Directory /Video/Сало, или 120 дней Содома _ Salo, or the 120 Days of Sodom _ Salo o le 120 giorna
    te di Sodoma (Пьер Паоло Пазолини _ Pier Paolo Paso
    >dr-xr-xr-x     0     0         0 27-Dec-2009 13:44 .
     dr-xr-xr-x     0     0         0 27-Mar-2013 22:23 ..
     dr-xr-xr-x     0     0         0 27-Dec-2009 07:31 BDMV
     -r--r--r--     0     0        48 27-Dec-2009 13:44 URL.txt
    
    when in:

    Code: Select all

    F:\Video\Сало, или 120 дней Содома _ Salo, or the 120 Days of Sodom _ Salo o le 120 giornate di Sodoma (Пьер Паоло Пазолини _ Pier Paolo Pasolini) [1975 г., ужасы, драма, военный, BDRemux] AVO (Кузнецов) + original + sub
    
    Long dir names are still being cut.
  2. Files and dirs aren't sorted when selecting source, while they are when selecting target. I wrote about it earlier, so just to be precise. Besides, I'm not sure whether this sort is valid: dirs started with "_" are after dir started with "1" (see example in the next item).
  3. We have found a file to copy and pressed 'c':

    Code: Select all

    TestDisk 6.14-WIP, Data Recovery Utility, April 2013
    
    Please select a destination where /Video/Сало, или 120 дней
    Содома _ Salo, or the 120 Days of Sodom _ Salo o le 120 giornate di
    Sodoma (Пьер Паоло Пазолини _ Pier Paolo Pasolini) [1975 г.,
    ужасы, драма, военный, BDRemux] AVO (Кузнецов) +
    original + sub/BDMV/STREAM/00001.m2ts will be copied.
    Keys: Arrow keys to select another directory
          C when the destination is correct
          Q to quit
    Directory F:\Video
    >drwx------ 4294967295 4294967295         0 27-Mar-2013 22:23 .
     drwxrwx--- 4294967295 4294967295         0 14-Mar-2013 18:17 ..
     drwx------ 4294967295 4294967295         0 27-Dec-2009 13:41 11-14 (Одиннадцать четырнадцать) _ E
     drwx------ 4294967295 4294967295         0 10-Jan-2011 13:47 _4Kids
     drwx------ 4294967295 4294967295         0 10-Nov-2012 00:33 _Doc
     drwx------ 4294967295 4294967295         0  4-Jan-2013 02:34 _Extras
     drwx------ 4294967295 4294967295         0  4-Mar-2010 14:34 _Misc
     drwx------ 4294967295 4294967295         0  3-Jan-2011 03:20 _Music
     drwx------ 4294967295 4294967295         0 16-Dec-2012 19:20 Август Раш _ August Rush (Кирстен Ше
    
    Source dir isn't cut anymore, but its name is hardly readable. It would be better to use separate lines:

    Code: Select all

    Please select a destination where
    /Video/Сало, или 120 дней Содома _ Salo, or the 120 Days
    of Sodom _ Salo o le 120 giornate di Sodoma (Пьер Паоло
    Пазолини _ Pier Paolo Pasolini) [1975 г., ужасы, драма,
    военный, BDRemux] AVO (Кузнецов) + original + sub/BDMV/
    STREAM/00001.m2ts
    will be copied.
    
  4. We can't see full names of possible destination dirs. It would be useful if we could scroll them by Alt-Left arrow and Alt-Right arrow (which uselessly duplicate simple Left/Right arrows at the moment) while the cursor is on them.
  5. "Copying, please wait..." message seems to be gone. That's what is being displayed after press 'c':

    Code: Select all

    TestDisk 6.14-WIP, Data Recovery Utility, April 2013
    
    Please select a destination where /00001.m2ts will be copied.
    Keys: Arrow keys to select another directory
          C when the destination is correct
          Q to quit
    Directory C:\
    >drwxrwxrwx     0     0         0                   .
     drwxrwxrwx     0     0         0                   ..
     drwxrwxrwx     0     0 21967908864                   00001.m2ts
    
    Hard disk is working but nothing on the screen tells us that something is in progress.
  6. For some unknown reason, I can't see directory

    Code: Select all

    F:\Video\Сало, или 120 дней Содома _ Salo, or the 120 Days of Sodom _ Salo o le 120 giornate di Sodoma (Пьер Паоло Пазолини _ Pier Paolo Pasolini) [1975 г., ужасы, драма, военный, BDRemux] AVO (Кузнецов) + original + sub
    
    while choosing destination dir (it is visible and available when selecting a file to copy).
  7. It would be better if drive list was a start point when choosing destination dir (now we always start from the dir that was current when testdisk_win.exe was launched - which has a little sense).
  8. TestDisk allows to copy a file from the root dir to the same root dir. So file is being replaced with itself (but what if it is 20GB big?)
  9. I'm not quite sure what "hide Alternate Data Stream" means but if it has something to do to my wish about "phatom" files then it doesn't seem to work.

User avatar
cgrenier
Site Admin
Posts: 3613
Joined: 18 Feb 2012, 15:08
Location: Le Perreux Sur Marne, France
Contact:

Re: Copying - feature requests

#6 Post by cgrenier » 28 Apr 2013, 11:05

New 6.14-WIP published
- source filenames are sorted when the source filesystem is NTFS
- '_' is after '1' in the ascii table, the sort is valid
- "Copying please wait" message should be back when copying a single file

GCRaistlin
Posts: 9
Joined: 09 Feb 2013, 21:35

Re: Copying - feature requests

#7 Post by GCRaistlin » 29 Apr 2013, 15:32

cgrenier wrote:- source filenames are sorted when the source filesystem is NTFS
Confirmed.
cgrenier wrote:- '_' is after '1' in the ascii table, the sort is valid
I see it is nominally, but the fact is that "_" as well as '`' are used in the beginning of the file name to get it in the beginning of dir listing. So if "_foobar" would be before "foobar" it won't harm anyone but will be useful for some Windows users ('cause Explorer and Far sort filenames this way).
cgrenier wrote:- "Copying please wait" message should be back when copying a single file
Confirmed.

Other items from my previous post are still actual.

Post Reply

Who is online

Users browsing this forum: No registered users and 0 guests